manika137 commented on code in PR #7122: URL: https://github.com/apache/hadoop/pull/7122#discussion_r1860037701
########## hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/services/TestAbfsBackoffMetrics.java: ########## @@ -0,0 +1,115 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hadoop.fs.azurebfs.services; + +import org.assertj.core.api.Assertions; +import org.junit.Before; +import org.junit.Test; + +import static org.apache.hadoop.fs.azurebfs.enums.AbfsBackoffMetricsEnum.NUMBER_OF_REQUESTS_SUCCEEDED; +import static org.apache.hadoop.fs.azurebfs.enums.AbfsBackoffMetricsEnum.TOTAL_NUMBER_OF_REQUESTS; +import static org.apache.hadoop.fs.azurebfs.enums.RetryValue.ONE; +import static org.apache.hadoop.fs.azurebfs.enums.RetryValue.THREE; +import static org.apache.hadoop.fs.azurebfs.enums.RetryValue.TWO; +import static org.apache.hadoop.fs.azurebfs.enums.StatisticTypeEnum.TYPE_COUNTER; +import static org.apache.hadoop.fs.azurebfs.enums.StatisticTypeEnum.TYPE_GAUGE; + +public class TestAbfsBackoffMetrics { + private AbfsBackoffMetrics metrics; + private static final int TOTAL_COUNTERS = 22; + private static final int TOTAL_GAUGES = 21; + + /** + * Sets up the test environment by initializing the AbfsBackoffMetrics instance. + */ + @Before + public void setUp() { + metrics = new AbfsBackoffMetrics(); + } + + /** + * Tests the retrieval of metric names based on the statistic type. + */ + @Test + public void retrievesMetricNamesBasedOnStatisticType() { + String[] counterMetrics = metrics.getMetricNamesByType(TYPE_COUNTER); + String[] gaugeMetrics = metrics.getMetricNamesByType(TYPE_GAUGE); + Assertions.assertThat(counterMetrics.length) + .describedAs("Counter metrics should have 22 elements") + .isEqualTo(TOTAL_COUNTERS); + Assertions.assertThat(gaugeMetrics.length) + .describedAs("Counter metrics should have 21 elements") Review Comment: This should be gauge instead of counter I think -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
