KevinWikant commented on PR #7179:
URL: https://github.com/apache/hadoop/pull/7179#issuecomment-2555346014
Thank you @vnhive @Hexiaoqiao & @shameersss1 for the feedback on this
change. Apologies for the delayed response, I was out travelling past several
days.
I will address the remaining Javadoc & Spotbugs warnings. I will also
address all of the above conversations/comments.
Note that the unit test failures are unrelated:
```
[INFO] Results:
[INFO]
[ERROR] Failures:
[ERROR]
org.apache.hadoop.hdfs.TestRollingUpgrade.testDFSAdminRollingUpgradeCommands(org.apache.hadoop.hdfs.TestRollingUpgrade)
[ERROR] Run 1:
TestRollingUpgrade.testDFSAdminRollingUpgradeCommands:115->checkMxBeanIsNull:308
expected null, but
was:<javax.management.openmbean.CompositeDataSupport(compositeType=javax.management.openmbean.CompositeType(name=org.apache.hadoop.hdfs.protocol.RollingUpgradeInfo$Bean,items=((itemName=blockPoolId,itemType=javax.management.openmbean.SimpleType(name=java.lang.String)),(itemName=createdRollbackImages,itemType=javax.management.openmbean.SimpleType(name=java.lang.Boolean)),(itemName=finalizeTime,itemType=javax.management.openmbean.SimpleType(name=java.lang.Long)),(itemName=startTime,itemType=javax.management.openmbean.SimpleType(name=java.lang.Long)))),contents={blockPoolId=BP-1510961105-172.17.0.2-1733436045661,
createdRollbackImages=true, finalizeTime=0, startTime=1733436049973})>
[ERROR] Run 2:
TestRollingUpgrade.testDFSAdminRollingUpgradeCommands:115->checkMxBeanIsNull:308
expected null, but
was:<javax.management.openmbean.CompositeDataSupport(compositeType=javax.management.openmbean.CompositeType(name=org.apache.hadoop.hdfs.protocol.RollingUpgradeInfo$Bean,items=((itemName=blockPoolId,itemType=javax.management.openmbean.SimpleType(name=java.lang.String)),(itemName=createdRollbackImages,itemType=javax.management.openmbean.SimpleType(name=java.lang.Boolean)),(itemName=finalizeTime,itemType=javax.management.openmbean.SimpleType(name=java.lang.Long)),(itemName=startTime,itemType=javax.management.openmbean.SimpleType(name=java.lang.Long)))),contents={blockPoolId=BP-1510961105-172.17.0.2-1733436045661,
createdRollbackImages=true, finalizeTime=0, startTime=1733436049973})>
[ERROR] Run 3:
TestRollingUpgrade.testDFSAdminRollingUpgradeCommands:115->checkMxBeanIsNull:308
expected null, but
was:<javax.management.openmbean.CompositeDataSupport(compositeType=javax.management.openmbean.CompositeType(name=org.apache.hadoop.hdfs.protocol.RollingUpgradeInfo$Bean,items=((itemName=blockPoolId,itemType=javax.management.openmbean.SimpleType(name=java.lang.String)),(itemName=createdRollbackImages,itemType=javax.management.openmbean.SimpleType(name=java.lang.Boolean)),(itemName=finalizeTime,itemType=javax.management.openmbean.SimpleType(name=java.lang.Long)),(itemName=startTime,itemType=javax.management.openmbean.SimpleType(name=java.lang.Long)))),contents={blockPoolId=BP-1510961105-172.17.0.2-1733436045661,
createdRollbackImages=true, finalizeTime=0, startTime=1733436049973})>
[INFO]
[ERROR] Errors:
[ERROR]
org.apache.hadoop.hdfs.TestRollingUpgrade.testRollback(org.apache.hadoop.hdfs.TestRollingUpgrade)
[ERROR] Run 1: TestRollingUpgrade.testRollback:337->waitForNullMxBean:367
» Timeout Timed out...
[ERROR] Run 2: TestRollingUpgrade.testRollback:337->waitForNullMxBean:367
» Timeout Timed out...
[ERROR] Run 3: TestRollingUpgrade.testRollback:337->waitForNullMxBean:367
» Timeout Timed out...
[INFO]
[WARNING] Flakes:
[WARNING]
org.apache.hadoop.hdfs.TestRollingUpgrade.testRollBackImage(org.apache.hadoop.hdfs.TestRollingUpgrade)
[ERROR] Run 1: TestRollingUpgrade.testRollBackImage:645 Test resulted in
an unexpected exit: 1: java.io.IOException: All the storage failed while
writing properties to VERSION file
[INFO] Run 2: PASS
[INFO]
[WARNING]
org.apache.hadoop.hdfs.server.balancer.TestBalancerRPCDelay.testBalancerRPCDelayQps3(org.apache.hadoop.hdfs.server.balancer.TestBalancerRPCDelay)
[ERROR] Run 1: TestBalancerRPCDelay.testBalancerRPCDelayQps3:52 »
UnfinishedStubbing
Unfinis...
[ERROR] Run 2: TestBalancerRPCDelay.teardown:46 Test resulted in an
unexpected exit: 1: Block report processor encountered fatal exception:
java.lang.ClassCastException: java.lang.Boolean cannot be cast to
org.apache.hadoop.hdfs.server.protocol.BlocksWithLocations
[INFO] Run 3: PASS
[INFO]
[WARNING]
org.apache.hadoop.hdfs.server.datanode.TestBlockReplacement.testBlockReplacementWithPinnedBlocks(org.apache.hadoop.hdfs.server.datanode.TestBlockReplacement)
[ERROR] Run 1:
TestBlockReplacement.testBlockReplacementWithPinnedBlocks:260 Status code
mismatches!
[INFO] Run 2: PASS
[INFO]
[WARNING]
org.apache.hadoop.hdfs.server.namenode.ha.TestPipelinesFailover.testFailoverRightBeforeCommitSynchronization(org.apache.hadoop.hdfs.server.namenode.ha.TestPipelinesFailover)
[ERROR] Run 1:
TestPipelinesFailover.testFailoverRightBeforeCommitSynchronization:380 »
TestTimedOut
[INFO] Run 2: PASS
[INFO]
[INFO]
[ERROR] Tests run: 7072, Failures: 1, Errors: 1, Skipped: 25, Flakes: 4
[INFO]
[ERROR] There are test failures.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
