KevinWikant commented on code in PR #7179:
URL: https://github.com/apache/hadoop/pull/7179#discussion_r1892968157
##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSConfigKeys.java:
##########
@@ -1744,6 +1744,27 @@ public class DFSConfigKeys extends
CommonConfigurationKeys {
public static final boolean
DFS_DATANODE_LOCKMANAGER_TRACE_DEFAULT = false;
+ /**
+ * A datanode should only enter decommissioned state if all blocks
+ * on the datanode are sufficiently replicated to other live datanodes.
+ *
+ * When this setting is disabled, the Namenode does not consider
+ * Under Construction blocks in determining if a datanode can be
+ * decommissioned; this results in scenarios where datanodes enter
+ * decommissioned state before their blocks are sufficiently replicated
+ * to other live datanodes. This can lead to HDFS write failures and
+ * data loss, if all the datanodes in the block write pipeline are
+ * decommissioned and terminated at around the same time.
+ *
+ * Enable the following setting to have the Namenode track and consider
+ * Under Construction blocks when identifying if a datanode can be
+ * decommissioned.
+ */
+ public static final String DFS_DECOMMISSION_TRACK_UNDER_CONSTRUCTION_BLOCKS =
Review Comment:
I will use the version of the comment which you have suggested above:
```
/**
* Determines whether the NameNode tracks under-construction blocks when
decommissioning DataNodes.
*
* A DataNode should only enter decommissioned state if all blocks on the
DataNode are
* sufficiently replicated to other live DataNodes.
*
* When this setting is disabled, the NameNode does not consider
under-construction blocks
* in determining if a DataNode can be decommissioned. This can result in
scenarios where
* DataNodes enter decommissioned state before their blocks are sufficiently
replicated
* to other live DataNodes.
*
* This situation can lead to HDFS write failures and data loss if all the
DataNodes in
* the block write pipeline are decommissioned and terminated at around the
same time.
*
* Enable this setting to have the NameNode track and consider
under-construction blocks
* when identifying if a DataNode can be decommissioned.
*/
```
Please let me know if there are still any concerns about the wording
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
