ahmarsuhail opened a new pull request, #7237: URL: https://github.com/apache/hadoop/pull/7237
### Description of PR This PR makes some additional changes to the initial PR from Steve: https://github.com/apache/hadoop/pull/7214. Not sure if I got all of this right, but here are a few callouts: * Thought of moving InputStreamCallbacks into S3AStore, but I don't think that is the right place for it. InputStreamCallBacks uses `S3AFileSystemOperations`, which uses `S3AStore`, so you end up in a dependency mess. Instead, move them to a separate class `InputStreamCallbacksImpl`, which keeps the code out of S3AFileSystem. Maybe there is a better way to do this, but I couldn't think of anything. * Adds a new config, `fs.s3a.input.stream.type`. This can be set to `classic`, `prefetch`, `analytics`. Believe this is better than having multiple`prefetch.enabled` and `analytics.enabled` flags. * Could not figure out what was meant by "S3Store to implement the factory interface, completing final binding operations (callbacks, stats)" in Steve's original PR, let's discuss. * This is a draft PR, was just attempting to complete the original PR. ### How was this patch tested? Not tested. Whoever picks this up for completion can test! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
