[
https://issues.apache.org/jira/browse/HADOOP-19232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17911395#comment-17911395
]
ASF GitHub Bot commented on HADOOP-19232:
-----------------------------------------
anmolanmol1234 commented on code in PR #7272:
URL: https://github.com/apache/hadoop/pull/7272#discussion_r1908443326
##########
hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestAbfsCustomEncryption.java:
##########
@@ -310,12 +322,26 @@ private AbfsRestOperation
callOperation(AzureBlobFileSystem fs,
}
}
case WRITE:
- return client.flush(path, 3, false, false, null,
- null, encryptionAdapter, getTestTracingContext(fs, false));
+ if (ingressClient instanceof AbfsDfsClient) {
+ return ingressClient.flush(path, 3, false, false, null,
+ null, encryptionAdapter, getTestTracingContext(fs, false));
+ } else {
+ byte[] buffer =
generateBlockListXml().getBytes(StandardCharsets.UTF_8);
+ return ingressClient.flush(buffer, path, false, null,
+ null, null, encryptionAdapter, getTestTracingContext(fs, false));
+ }
case APPEND:
- return client.append(path, "val".getBytes(),
- new AppendRequestParameters(3, 0, 3, APPEND_MODE, false, null,
true),
- null, encryptionAdapter, getTestTracingContext(fs, false));
+ if (ingressClient instanceof AbfsDfsClient) {
+ return ingressClient.append(path, "val".getBytes(),
+ new AppendRequestParameters(3, 0, 3, APPEND_MODE, false, null,
+ true),
+ null, encryptionAdapter, getTestTracingContext(fs, false));
+ } else {
+ return ingressClient.append(path, "val".getBytes(),
+ new AppendRequestParameters(3, 0, 3, APPEND_MODE, false, null,
+ true, new
BlobAppendRequestParameters("MF8tNDE1MjkzOTE4AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA",
null)),
Review Comment:
taken
> ABFS: [FnsOverBlob] Implementing Ingress Support with various Fallback
> Handling
> -------------------------------------------------------------------------------
>
> Key: HADOOP-19232
> URL: https://issues.apache.org/jira/browse/HADOOP-19232
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/azure
> Affects Versions: 3.4.0
> Reporter: Descifrado
> Assignee: Anmol Asrani
> Priority: Major
> Labels: pull-request-available
>
> Scope of this task is to refactor the AbfsOutputStream class to handle the
> ingress for DFS and Blob endpoint effectively.
> More details will be added soon.
> Perquisites for this Patch:
> 1. [HADOOP-19187] ABFS: [FnsOverBlob]Making AbfsClient Abstract for
> supporting both DFS and Blob Endpoint - ASF JIRA (apache.org)
> 2. [HADOOP-19226] ABFS: [FnsOverBlob]Implementing Azure Rest APIs on Blob
> Endpoint for AbfsBlobClient - ASF JIRA (apache.org)
> 3. [HADOOP-19207] ABFS: [FnsOverBlob]Response Handling of Blob Endpoint APIs
> and Metadata APIs - ASF JIRA (apache.org)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
