[
https://issues.apache.org/jira/browse/HADOOP-19232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17911396#comment-17911396
]
ASF GitHub Bot commented on HADOOP-19232:
-----------------------------------------
anmolanmol1234 commented on code in PR #7272:
URL: https://github.com/apache/hadoop/pull/7272#discussion_r1908444365
##########
hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/AbstractAbfsIntegrationTest.java:
##########
@@ -575,4 +590,52 @@ protected void assumeValidAuthConfigsPresent() {
protected boolean isAppendBlobEnabled() {
return getRawConfiguration().getBoolean(FS_AZURE_TEST_APPENDBLOB_ENABLED,
false);
}
+
+ protected AbfsServiceType getAbfsServiceType() {
+ return abfsConfig.getFsConfiguredServiceType();
+ }
+
+ /**
+ * Create directory with implicit parent directory.
+ * @param path path to create. Can be relative or absolute.
+ */
+ protected void createAzCopyFolder(Path path) throws Exception {
+ assumeValidTestConfigPresent(getRawConfiguration(),
FS_AZURE_TEST_FIXED_SAS_TOKEN);
+ String sasToken = getRawConfiguration().get(FS_AZURE_TEST_FIXED_SAS_TOKEN);
+ AzcopyToolHelper azcopyHelper = AzcopyToolHelper.getInstance(sasToken);
+ azcopyHelper.createFolderUsingAzcopy(getAzcopyAbsolutePath(path));
+ }
+
+ /**
+ * Create file with implicit parent directory.
+ * @param path path to create. Can be relative or absolute.
+ */
+ protected void createAzCopyFile(Path path) throws Exception {
+ assumeValidTestConfigPresent(getRawConfiguration(),
FS_AZURE_TEST_FIXED_SAS_TOKEN);
+ String sasToken = getRawConfiguration().get(FS_AZURE_TEST_FIXED_SAS_TOKEN);
+ AzcopyToolHelper azcopyHelper = AzcopyToolHelper.getInstance(sasToken);
+ azcopyHelper.createFileUsingAzcopy(getAzcopyAbsolutePath(path));
+ }
+
+ private String getAzcopyAbsolutePath(Path path) throws IOException {
+ String pathFromContainerRoot =
getFileSystem().makeQualified(path).toUri().getPath();
+ return HTTPS_SCHEME + COLON + FORWARD_SLASH + FORWARD_SLASH
+ + accountName + FORWARD_SLASH + fileSystemName + pathFromContainerRoot;
+ }
+
+ protected void assumeBlobServiceType() {
+ Assume.assumeTrue("Blob service type is required for this test",
+ getAbfsServiceType() == AbfsServiceType.BLOB);
+ }
+
+ /**
+ * Assert that the path contains the expected DNS suffix.
+ * If service type is blob, then path should have blob domain name.
+ * @param path to be asserted.
+ */
+ protected void assertPathDns(Path path) {
Review Comment:
taken
> ABFS: [FnsOverBlob] Implementing Ingress Support with various Fallback
> Handling
> -------------------------------------------------------------------------------
>
> Key: HADOOP-19232
> URL: https://issues.apache.org/jira/browse/HADOOP-19232
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/azure
> Affects Versions: 3.4.0
> Reporter: Descifrado
> Assignee: Anmol Asrani
> Priority: Major
> Labels: pull-request-available
>
> Scope of this task is to refactor the AbfsOutputStream class to handle the
> ingress for DFS and Blob endpoint effectively.
> More details will be added soon.
> Perquisites for this Patch:
> 1. [HADOOP-19187] ABFS: [FnsOverBlob]Making AbfsClient Abstract for
> supporting both DFS and Blob Endpoint - ASF JIRA (apache.org)
> 2. [HADOOP-19226] ABFS: [FnsOverBlob]Implementing Azure Rest APIs on Blob
> Endpoint for AbfsBlobClient - ASF JIRA (apache.org)
> 3. [HADOOP-19207] ABFS: [FnsOverBlob]Response Handling of Blob Endpoint APIs
> and Metadata APIs - ASF JIRA (apache.org)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
