anmolanmol1234 commented on code in PR #7272: URL: https://github.com/apache/hadoop/pull/7272#discussion_r1930436811
########## hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AzureBlobBlockManager.java: ########## @@ -0,0 +1,194 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hadoop.fs.azurebfs.services; + +import java.io.IOException; +import java.util.ArrayList; +import java.util.LinkedList; +import java.util.List; + +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import org.apache.hadoop.fs.azurebfs.contracts.exceptions.AzureBlobFileSystemException; +import org.apache.hadoop.fs.azurebfs.utils.TracingContext; +import org.apache.hadoop.fs.store.DataBlocks; + +/** + * Manages Azure Blob blocks for append operations. + */ +public class AzureBlobBlockManager extends AzureBlockManager { + + private static final Logger LOG = LoggerFactory.getLogger( + AbfsOutputStream.class); + + + /** The list of already committed blocks is stored in this list. */ + private List<String> committedBlockEntries = new ArrayList<>(); + + /** The list to store blockId, position, and status. */ + private final LinkedList<BlockEntry> blockEntryList = new LinkedList<>(); + + + /** + * Constructs an AzureBlobBlockManager. + * + * @param abfsOutputStream the output stream + * @param blockFactory the block factory + * @param bufferSize the buffer size + * @throws AzureBlobFileSystemException if an error occurs + */ + public AzureBlobBlockManager(AbfsOutputStream abfsOutputStream, + DataBlocks.BlockFactory blockFactory, + int bufferSize) + throws AzureBlobFileSystemException { + super(abfsOutputStream, blockFactory, bufferSize); + if (abfsOutputStream.getPosition() > 0 && !abfsOutputStream.isAppendBlob()) { + this.committedBlockEntries = getBlockList(abfsOutputStream.getTracingContext()); + } + LOG.debug("Created a new Blob Block Manager for AbfsOutputStream instance {} for path {}", + abfsOutputStream.getStreamID(), abfsOutputStream.getPath()); + } + + /** + * Creates a new block. + * + * @param position the position + * @return the created block + * @throws IOException if an I/O error occurs + */ + @Override + protected synchronized AbfsBlock createBlockInternal(long position) + throws IOException { + if (getActiveBlock() == null) { + setBlockCount(getBlockCount() + 1); + AbfsBlock activeBlock = new AbfsBlobBlock(getAbfsOutputStream(), position); + activeBlock.setBlockEntry(addNewEntry(activeBlock.getBlockId(), activeBlock.getOffset())); + setActiveBlock(activeBlock); + } + return getActiveBlock(); + } + + /** + * Returns block id's which are committed for the blob. + * + * @param tracingContext Tracing context object. + * @return list of committed block id's. + * @throws AzureBlobFileSystemException if an error occurs + */ + private List<String> getBlockList(TracingContext tracingContext) + throws AzureBlobFileSystemException { + List<String> committedBlockIdList = new ArrayList<>(); + AbfsBlobClient blobClient = getAbfsOutputStream().getClientHandler().getBlobClient(); + final AbfsRestOperation op = blobClient + .getBlockList(getAbfsOutputStream().getPath(), tracingContext); + if (op != null && op.getResult() != null) { + committedBlockIdList = op.getResult().getBlockIdList(); + } + return committedBlockIdList; + } + + /** + * Adds a new block entry to the block entry list. + * The block entry is added only if the position of the new block + * is greater than the position of the last block in the list. + * + * @param blockId The ID of the new block to be added. + * @param position The position of the new block in the stream. + * @return The newly added {@link BlockEntry}. + * @throws IOException If the position of the new block is not greater than the last block in the list. + */ + private synchronized BlockEntry addNewEntry(String blockId, long position) throws IOException { + if (!blockEntryList.isEmpty()) { + BlockEntry lastEntry = blockEntryList.getLast(); + if (position <= lastEntry.getPosition()) { + throw new IOException("New block position " + position + " must be greater than the last block position " + + lastEntry.getPosition() + " for path " + getAbfsOutputStream().getPath()); + } + } + BlockEntry blockEntry = new BlockEntry(blockId, position, AbfsBlockStatus.NEW); + blockEntryList.addLast(blockEntry); + LOG.debug("Added block {} at position {} with status NEW.", blockId, position); + return blockEntry; + } + + /** + * Updates the status of an existing block entry to SUCCESS. + * This method is used to mark a block as successfully processed. + * + * @param block The {@link AbfsBlock} whose status needs to be updated to SUCCESS. + */ + protected synchronized void updateEntry(AbfsBlock block) { + BlockEntry blockEntry = block.getBlockEntry(); + blockEntry.setStatus(AbfsBlockStatus.SUCCESS); + LOG.debug("Added block {} at position {} with status SUCCESS.", block.getBlockId(), blockEntry.getPosition()); + } + + /** + * Prepares the list of blocks to commit. + * + * @return whether we have some data to commit or not. + * @throws IOException if an I/O error occurs + */ + protected boolean hasListToCommit() throws IOException { Review Comment: The caller of this method is synchronized. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
