anmolanmol1234 commented on code in PR #7272:
URL: https://github.com/apache/hadoop/pull/7272#discussion_r1931002485
##########
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/AzureBlobFileSystem.java:
##########
@@ -234,6 +237,29 @@ public void initialize(URI uri, Configuration
configuration)
throw new
InvalidConfigurationValueException(FS_AZURE_ACCOUNT_IS_HNS_ENABLED, ex);
}
+ /*
+ * Validates if the correct SAS Token provider is configured for non-HNS
accounts.
+ * For non-HNS accounts, if the authentication type is set to SAS, only a
fixed SAS Token is supported as of now.
+ * A custom SAS Token Provider should not be configured in such cases, as
it will override the FixedSASTokenProvider and render it unused.
+ * If the namespace is not enabled and the FixedSASTokenProvider is not
configured,
+ * an InvalidConfigurationValueException will be thrown.
+ *
+ * @throws InvalidConfigurationValueException if account is not namespace
enabled and FixedSASTokenProvider is not configured.
+ */
+ try {
+ if (abfsConfiguration.getAuthType(abfsConfiguration.getAccountName()) ==
AuthType.SAS && // Auth type is SAS
+ !tryGetIsNamespaceEnabled(new TracingContext(initFSTracingContext))
&& // Account is FNS
Review Comment:
Since we a new object of Tracing context at different places, a common
variable will not suffice
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
