anmolanmol1234 commented on code in PR #7265:
URL: https://github.com/apache/hadoop/pull/7265#discussion_r1933339471
##########
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/BlobRenameHandler.java:
##########
@@ -518,17 +479,25 @@ private void copyPath(final Path src, final Path dst,
final String leaseId)
tracingContext, null, false);
final String srcCopyPath = ROOT_PATH +
getAbfsClient().getFileSystem()
+ src.toUri().getPath();
- if (dstPathStatus.getResult() != null && (srcCopyPath.equals(
- getDstSource(dstPathStatus)))) {
+ if (dstPathStatus != null && dstPathStatus.getResult() != null
+ && (srcCopyPath.equals(getDstSource(dstPathStatus)))) {
return;
}
}
throw ex;
}
final long pollWait = getAbfsClient().getAbfsConfiguration()
.getBlobCopyProgressPollWaitMillis();
+ final long maxWait = getAbfsClient().getAbfsConfiguration()
+ .getBlobCopyProgressMaxWaitMillis();
+ long startTime = System.currentTimeMillis();
while (handleCopyInProgress(dst, tracingContext, copyId)
== BlobCopyProgress.PENDING) {
+ if (System.currentTimeMillis() - startTime > maxWait) {
+ throw new TimeoutException(
+ "Blob copy progress wait time exceeded for source: "
Review Comment:
use {} format for messages instead of concat
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
