anmolanmol1234 commented on code in PR #7265:
URL: https://github.com/apache/hadoop/pull/7265#discussion_r1933372250
##########
hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestAzureBlobFileSystemDelete.java:
##########
@@ -227,6 +236,13 @@ public void testDeleteIdempotency() throws Exception {
public void testDeleteIdempotencyTriggerHttp404() throws Exception {
final AzureBlobFileSystem fs = getFileSystem();
+ /*
+ * Delete call for a folder on DFS endpoint is one-server call and the
+ * orchestration of delete of paths inside the directory. For Blob
+ * endpoint, the orchestration would be done by the client. The idempotency
+ * issue would not happen for blob endpoint.
+ */
+ assertTrue(fs.getAbfsClient() instanceof AbfsDfsClient);
Review Comment:
Yes checked now, this change will come as part of ingress PR
##########
hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestAzureBlobFileSystemDelete.java:
##########
@@ -314,4 +347,278 @@ public void
deleteBlobDirParallelThreadToDeleteOnDifferentTracingContext()
fs.delete(new Path("/testDir"), true);
fs.close();
}
+
+ private void assumeBlobClient() throws IOException {
Review Comment:
It is available in AbstractAbfsIntegrationTest class
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
