anujmodi2021 commented on code in PR #7265:
URL: https://github.com/apache/hadoop/pull/7265#discussion_r1933468312
##########
hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/services/ITestAbfsPaginatedDelete.java:
##########
@@ -142,6 +142,7 @@ private void setTestUserConf(Configuration conf, String
key, String value) {
*/
@Test
public void testRecursiveDeleteWithPagination() throws Exception {
+ assertTrue(getFileSystem().getAbfsStore().getClient() instanceof
AbfsDfsClient);
Review Comment:
Should it be assume here and other places in file??
Also instead of checking on instance of you can use methods defined in base
class for getting current servce type and use them
##########
hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/services/ITestAbfsClient.java:
##########
@@ -452,7 +452,6 @@ public static AbfsClient getMockAbfsClient(AbfsClient
baseAbfsClientInstance,
(currentAuthType == AuthType.SharedKey)
|| (currentAuthType == AuthType.OAuth));
- // TODO : [FnsOverBlob][HADOOP-19234] Update to work with Blob Endpoint as
well when Fns Over Blob is ready.
Review Comment:
Why we are removing this, we still not to update test to work with Blob
Client
##########
hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestAzureBlobFileSystemRenameUnicode.java:
##########
@@ -26,13 +26,19 @@
import org.apache.hadoop.fs.FileStatus;
import org.apache.hadoop.fs.Path;
+import org.apache.hadoop.fs.PathIOException;
Review Comment:
Import ordering fix
##########
hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestAzureBlobFileSystemRename.java:
##########
@@ -18,36 +18,83 @@
package org.apache.hadoop.fs.azurebfs;
+import java.io.IOException;
+import java.io.OutputStream;
+import java.nio.charset.StandardCharsets;
+import java.nio.file.AccessDeniedException;
import java.util.ArrayList;
import java.util.List;
import java.util.concurrent.Callable;
import java.util.concurrent.ExecutorService;
import java.util.concurrent.Executors;
import java.util.concurrent.Future;
+import java.util.concurrent.atomic.AtomicBoolean;
+import java.util.concurrent.atomic.AtomicInteger;
-import org.junit.Assert;
+import org.apache.hadoop.fs.FileSystem;
Review Comment:
Import ordering.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
