slfan1989 commented on code in PR #7345:
URL: https://github.com/apache/hadoop/pull/7345#discussion_r1951322995
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/api/impl/TestAMRMClient.java:
##########
@@ -560,13 +560,17 @@ public void testAMRMClientMatchStorage() throws
YarnException, IOException {
}
}
- assertEquals(2, allocatedContainerCount);
+ assertTrue(allocatedContainerCount <= 2);
Review Comment:
@cnauroth I came up with a middle-ground solution. Could we temporarily mark
the three frequently failing unit tests in `TestAMRMClient.java` as `Ignore`
and re-enable them once they are fixed? This way, we won't need to make
immediate changes to `TestAMRMClient.java`, and we can still start the upgrade
of YARN from JUnit 4 to JUnit 5.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
