slfan1989 commented on code in PR #7345:
URL: https://github.com/apache/hadoop/pull/7345#discussion_r1958958420
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/api/impl/TestAMRMClient.java:
##########
@@ -560,13 +560,17 @@ public void testAMRMClientMatchStorage() throws
YarnException, IOException {
}
}
- assertEquals(2, allocatedContainerCount);
+ assertTrue(allocatedContainerCount <= 2);
Review Comment:
@steveloughran @ayushtkn @Hexiaoqiao This week, I plan to focus on upgrading
`YARN` to JUnit 5. This PR needs to be merged first, as it addresses some
existing issues with the current JUnit setup. We have some disagreements
regarding the improvements to certain methods in `TestAMRMClient.java`. My
suggestion is to temporarily mark several flaky tests as "Ignore". This way, we
can prioritize advancing the JUnit 5 upgrade for YARN and revisit these
specific tests for further improvement later.
cc: @cnauroth
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
