steveloughran commented on code in PR #7369:
URL: https://github.com/apache/hadoop/pull/7369#discussion_r1951287559
##########
hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azure/AbstractWasbTestBase.java:
##########
@@ -146,31 +147,37 @@ protected Path path(String filepath) throws IOException {
/**
* Return a path bonded to this method name, unique to this fork during
* parallel execution.
+ * @param testInfo Provides information about the currently executing test
method.
+ * This can include details such as the name of the test method, display
name.
* @return a method name unique to (fork, method).
* @throws IOException IO problems
*/
- protected Path methodPath() throws IOException {
- return path(methodName.getMethodName());
+ protected Path methodPath(TestInfo testInfo) throws IOException {
Review Comment:
why is Junit 5 trying to ruin our lives. Everything *worked*.
setup should be caching that testinfo for the current suite, and all these
helper methods just using that to derive values. we shouldn't be passing it down
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
