steveloughran commented on code in PR #7284:
URL: https://github.com/apache/hadoop/pull/7284#discussion_r1973714219
##########
hadoop-tools/hadoop-aws/src/site/markdown/tools/hadoop-aws/authentication.md:
##########
@@ -222,6 +226,21 @@ Note:
configuration files MUST be in the `~/.aws/` directory on the local
filesystem in
all hosts in the cluster.
+### <a name="auth_simple"></a> Credentials from profile with
`ProfileAWSCredentialsProvider`*
+
+This is a non-default provider that fetches credentials from a profile file,
+acting as a Hadoop wrapper around ProfileCredentialsProvider. The profile file
and
+profile name are both resolved as follows.
+
+1. If the configuration setting is specified, that takes priority
(`fs.s3a.auth.profile.file`
+ for profile file and `fs.s3a.auth.profile.name` for profile name).
+2. If a configuration setting is absent, but the environment variables for
+ the setting(AWS_SHARED_CREDENTIALS_FILE for profile file and AWS_PROFILE for
+ profile name) is defined, then the variable is used.
+3. If neither configuration setting nor environment variable is present, then
+ the values default to `~/.aws/credentials` for the profile file, and
`default`
+ for the profile name.
+
Review Comment:
Add the paragraph
```
*Important*: This profile file must be on every node in the _cluster_.
If this is not the case, delegation tokens can be used to collect the
current credentials and propagate them
```
##########
hadoop-tools/hadoop-aws/src/site/markdown/tools/hadoop-aws/authentication.md:
##########
@@ -222,6 +226,21 @@ Note:
configuration files MUST be in the `~/.aws/` directory on the local
filesystem in
all hosts in the cluster.
+### <a name="auth_simple"></a> Credentials from profile with
`ProfileAWSCredentialsProvider`*
+
+This is a non-default provider that fetches credentials from a profile file,
+acting as a Hadoop wrapper around ProfileCredentialsProvider. The profile file
and
Review Comment:
expand to fill class reference of the AWS class
##########
hadoop-tools/hadoop-aws/src/site/markdown/tools/hadoop-aws/authentication.md:
##########
@@ -222,6 +226,21 @@ Note:
configuration files MUST be in the `~/.aws/` directory on the local
filesystem in
all hosts in the cluster.
+### <a name="auth_simple"></a> Credentials from profile with
`ProfileAWSCredentialsProvider`*
+
+This is a non-default provider that fetches credentials from a profile file,
+acting as a Hadoop wrapper around ProfileCredentialsProvider. The profile file
and
+profile name are both resolved as follows.
+
+1. If the configuration setting is specified, that takes priority
(`fs.s3a.auth.profile.file`
+ for profile file and `fs.s3a.auth.profile.name` for profile name).
+2. If a configuration setting is absent, but the environment variables for
+ the setting(AWS_SHARED_CREDENTIALS_FILE for profile file and AWS_PROFILE for
Review Comment:
nits
* add a space between setting and (
* use backticks to format env vars as code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
