steveloughran commented on PR #7284:
URL: https://github.com/apache/hadoop/pull/7284#issuecomment-2732736540
checkstyle is really, really close. Get that fixed ASAP and I will merge.
```
./hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/auth/ProfileAWSCredentialsProvider.java:44:
/** Conf setting for credentials file path*/: First sentence should end with
a period. [JavadocStyle]
./hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/auth/ProfileAWSCredentialsProvider.java:47:
/** Conf setting for profile name*/: First sentence should end with a period.
[JavadocStyle]
./hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/auth/ProfileAWSCredentialsProvider.java:50:
/** Environment variable for credentials file path*/: First sentence should
end with a period. [JavadocStyle]
./hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/auth/ProfileAWSCredentialsProvider.java:52:
/** Environment variable for profile name*/: First sentence should end with a
period. [JavadocStyle]
./hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/auth/ProfileAWSCredentialsProvider.java:64:
}:5: '}' at column 5 should be on the same line as the next part of a
multi-block statement (one that directly contains multiple blocks:
if/else-if/else, do/while or try/catch/finally). [RightCurly]
./hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/auth/ProfileAWSCredentialsProvider.java:70:
return
FileSystems.getDefault().getPath(SystemUtils.getUserHome().getPath(),".aws",
"credentials");: Line is longer than 100 characters (found 105). [LineLength]
./hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/auth/ProfileAWSCredentialsProvider.java:70:
return
FileSystems.getDefault().getPath(SystemUtils.getUserHome().getPath(),".aws",
"credentials");:82: ',' is not followed by whitespace. [WhitespaceAfter]
./hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/auth/ProfileAWSCredentialsProvider.java:71:
}:5: '}' at column 5 should be on the same line as the next part of a
multi-block statement (one that directly contains multiple blocks:
if/else-if/else, do/while or try/catch/finally). [RightCurly]
./hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/auth/ProfileAWSCredentialsProvider.java:84:
}:7: '}' at column 7 should be on the same line as the next part of a
multi-block statement (one that directly contains multiple blocks:
if/else-if/else, do/while or try/catch/finally). [RightCurly]
./hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/auth/ProfileAWSCredentialsProvider.java:88:
}:5: '}' at column 5 should be on the same line as the next part of a
multi-block statement (one that directly contains multiple blocks:
if/else-if/else, do/while or try/catch/finally). [RightCurly]
./hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/TestS3AAWSCredentialsProvider.java:152:
try (FileWriter fileWriter = new FileWriter(tempFile); BufferedWriter
bufferedWriter = new BufferedWriter(fileWriter)) {: Line is longer than 100
characters (found 124). [LineLength]
./hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/TestS3AAWSCredentialsProvider.java:154:
+ "aws_access_key_id = defaultaccesskeyid\n": 'method call' child has
incorrect indentation level 6, expected level should be 8. [Indentation]
./hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/TestS3AAWSCredentialsProvider.java:155:
+ "aws_secret_access_key = defaultsecretkeyid\n");: 'method call' child
has incorrect indentation level 6, expected level should be 8. [Indentation]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
