ahmarsuhail commented on code in PR #7443: URL: https://github.com/apache/hadoop/pull/7443#discussion_r1977672159
########## hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/impl/AWSRegionEndpointInformation.java: ########## @@ -0,0 +1,70 @@ +package org.apache.hadoop.fs.s3a.impl; + Review Comment: @steveloughran starting to work on the CRT changes, wanted to get your opinion on this. What do you think about doing some refactoring around this region logic, so we have our own builder and container class for `AWSRegionEndpointInformation` which all clients can get information out of. Without this you have to duplicate the endpoint region logic for CRT and the other clients since they use different builder classes. CRT uses `S3CrtAsyncClientBuilder` which does not extend `S3BaseClientBuilder` and so you can't use the existing method.. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
