ahmarsuhail commented on code in PR #7443:
URL: https://github.com/apache/hadoop/pull/7443#discussion_r1985149106
##########
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/impl/ClientManagerImpl.java:
##########
@@ -142,12 +148,18 @@ private CallableRaisingIOE<S3Client> createS3Client() {
* @return a callable which will create the client.
*/
private CallableRaisingIOE<S3AsyncClient> createAsyncClient() {
- return trackDurationOfOperation(
- durationTrackerFactory,
- STORE_CLIENT_CREATION.getSymbol(),
- () -> clientFactory.createS3AsyncClient(getUri(),
clientCreationParameters));
+ return trackDurationOfOperation(durationTrackerFactory,
STORE_CLIENT_CREATION.getSymbol(),
Review Comment:
this should actually go into the client factory, not here. moving this over
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
