hfutatzhanghb commented on PR #7470: URL: https://github.com/apache/hadoop/pull/7470#issuecomment-2702965149
> > @slfan1989 Sir, thanks so much for providing the approach to solve this problem gracefully. I will dive into these two suggestions and push this pr soonly. BTW, i think below PRs will not be blocked by this pr, because below PRs just add two classes and i will refactor them after merging or even ignore them. What's your opinions? #7445 #7462 #7464 #7466 > > @Hexiaoqiao @KeeProMise Sir, please also cc. Thanks all again. > > @hfutatzhanghb I have no objections to other PRs, but if you need to make large-scale modifications to the unit tests to support ARR, feel free to @ me, and we can discuss it further. We aim to improve the system through unit tests, but we also want to adopt a better approach, rather than just relying on class inheritance. Thanks again for your contribution! Sir, totally agree with you, we should make system robust and code clean in the meantime. Thanks for your help. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
