KeeProMise commented on PR #7470: URL: https://github.com/apache/hadoop/pull/7470#issuecomment-2771113332
> > Hi, @slfan1989 @KeeProMise @Hexiaoqiao . I wonder that whether should we split this PR or not ? If all in one, it would be unfriendly for reivewing. What's your opinions? > > @hfutatzhanghb Thank you for the information! I think we should first focus on updating all the unit tests in a single pr, and then consider splitting the changes into multiple prs afterward. > > I believe a single PR should not exceed 3000 lines or affect more than 50 classes. Since we're only improving unit tests and not modifying core logic, the review effort should be manageable. +1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
