stoty commented on code in PR #7512:
URL: https://github.com/apache/hadoop/pull/7512#discussion_r2007262765
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/TestLinuxContainerExecutorWithMocks.java:
##########
@@ -311,6 +312,12 @@ public void testStartLocalizer() throws IOException {
.build());
List<String> result=readMockParams();
+
+ if (Shell.isJavaVersionAtLeast(17)) {
+
assertTrue(result.remove("--add-exports=java.base/sun.net.dns=ALL-UNNAMED"));
+
assertTrue(result.remove("--add-exports=java.base/sun.net.util=ALL-UNNAMED"));
Review Comment:
As for comments, most tests in TestContainerLocalizer already have similar
ifs for JDK17 (I guess these were just added later, and never tested with
JDK17).
Would you like me to add comments to those as well ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
