pan3793 commented on code in PR #7512:
URL: https://github.com/apache/hadoop/pull/7512#discussion_r2007147809
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/TestLinuxContainerExecutorWithMocks.java:
##########
@@ -311,6 +312,12 @@ public void testStartLocalizer() throws IOException {
.build());
List<String> result=readMockParams();
+
+ if (Shell.isJavaVersionAtLeast(17)) {
+
assertTrue(result.remove("--add-exports=java.base/sun.net.dns=ALL-UNNAMED"));
+
assertTrue(result.remove("--add-exports=java.base/sun.net.util=ALL-UNNAMED"));
Review Comment:
MAPREDUCE-7456 defines
```
private static final String ADDITIONAL_JDK17_PLUS_OPTIONS =
"--add-opens=java.base/java.lang=ALL-UNNAMED " +
"--add-exports=java.base/sun.net.dns=ALL-UNNAMED " +
"--add-exports=java.base/sun.net.util=ALL-UNNAMED";
```
Why should only the last two be removed?
BTW, could you please leave a few comments that at least mention
MAPREDUCE-7456 ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
