bhattmanish98 commented on code in PR #7509:
URL: https://github.com/apache/hadoop/pull/7509#discussion_r2021107942
##########
hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/services/TestAbfsRenameRetryRecovery.java:
##########
@@ -275,9 +284,14 @@ public void testRenameRecoveryEtagMatchFsLevel() throws
IOException {
// 4 calls should have happened in total for rename
// 1 -> original rename rest call, 2 -> first retry,
// +2 for getPathStatus calls
+ int totalConnections = 4;
+ if (!getConfiguration().getIsClientTransactionIdEnabled()) {
Review Comment:
In case of recovery using client transaction id: It makes total 4 calls
1. getFileStatus - AzureBlobFileSystem
2. rename (without retry)
3. rename (1st retry)
4. getPathStatus -> to get client transaction Id
In case of recovery using Etag: It makes total 5 calls
1. getFileStatus - AzureBlobFileSystem
2. getPathStatus - to fetch etag of source
3. rename (without retry)
4. rename (1st retry)
5. getPathStatus - to fetch etag of destination
Before this change, `2. getPathStatus - to fetch etag of source` in case 2
was done even in case 1.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
