bhattmanish98 commented on code in PR #7509:
URL: https://github.com/apache/hadoop/pull/7509#discussion_r2021132520
##########
hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/services/TestAbfsRenameRetryRecovery.java:
##########
@@ -350,21 +364,18 @@ public void testRenameRecoveryFailsForDirFsLevel() throws
Exception {
if (getConfiguration().getIsClientTransactionIdEnabled()) {
// Recovery based on client transaction id should be successful
assertTrue(renameResult);
- // One extra getPathStatus call should have happened
- newConnections = 5;
} else {
assertFalse(renameResult);
- newConnections = 4;
}
// validating stat counters after rename
- // 3 calls should have happened in total for rename
+ // 4 calls should have happened in total for rename
// 1 -> original rename rest call, 2 -> first retry,
// +1 for getPathStatus calls
// last getPathStatus call should be skipped
assertThatStatisticCounter(ioStats,
CONNECTIONS_MADE.getStatName())
- .isEqualTo(newConnections + connMadeBeforeRename);
+ .isEqualTo(4 + connMadeBeforeRename);
Review Comment:
In the rename operation, we are adding 4 extra connections, which is why
it’s kept like this. We are following the same format in other places as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
