anujmodi2021 commented on code in PR #7582:
URL: https://github.com/apache/hadoop/pull/7582#discussion_r2031074033
##########
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsBlobClient.java:
##########
@@ -1620,19 +1618,17 @@ public ListResponseData
parseListPathResults(AbfsHttpOperation result, URI uri)
LOG.debug("ListBlobs listed {} blobs with {} as continuation token",
listResultSchema.paths().size(),
listResultSchema.getNextMarker());
- } catch (SAXException | IOException e) {
- throw new AbfsDriverException(e);
+ return filterDuplicateEntriesAndRenamePendingFiles(listResultSchema,
uri);
+ } catch (SAXException | IOException ex) {
+ throw new AbfsDriverException(ERR_BLOB_LIST_PARSING, ex);
}
- } catch (IOException e) {
- LOG.error("Unable to deserialize list results for uri {}",
uri.toString(), e);
- throw new AbfsDriverException(ERR_BLOB_LIST_PARSING, e);
- }
-
- try {
- return filterDuplicateEntriesAndRenamePendingFiles(listResultSchema,
uri);
- } catch (IOException e) {
- LOG.error("Unable to filter list results for uri {}", uri.toString(), e);
- throw new AbfsDriverException(ERR_BLOB_LIST_PARSING, e);
+ } catch (AbfsDriverException ex) {
+ // Throw as it is to avoid multiple wrapping.
+ LOG.error("Unable to deserialize list results for Uri {}", uri != null ?
uri.toString(): "NULL", ex);
Review Comment:
uri can be null for the cases where this API is called by internal
operations like in create flow.
If list call is coming from user, uri won't be null.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
