bhattmanish98 commented on code in PR #7582:
URL: https://github.com/apache/hadoop/pull/7582#discussion_r2030748158
##########
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsBlobClient.java:
##########
@@ -1606,10 +1607,7 @@ public Hashtable<String, String>
getXMSProperties(AbfsHttpOperation result)
public ListResponseData parseListPathResults(AbfsHttpOperation result, URI
uri)
throws AzureBlobFileSystemException {
BlobListResultSchema listResultSchema;
- try (InputStream stream = result.getListResultStream()) {
- if (stream == null) {
- return null;
- }
+ try (InputStream stream = new
ByteArrayInputStream(result.getListResultData())) {
Review Comment:
Will there be any issue here in case result.getListResultData() is null?
##########
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsHttpOperation.java:
##########
@@ -438,6 +438,11 @@ final void parseResponse(final byte[] buffer,
method, getMaskedUrl(), ex.getMessage());
log.debug("IO Error: ", ex);
throw ex;
+ } catch (Exception ex) {
+ log.warn("Unexpected error: {} {}: {}",
Review Comment:
Why do we need both log.warn and log.debug here?
##########
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsBlobClient.java:
##########
@@ -1620,19 +1618,17 @@ public ListResponseData
parseListPathResults(AbfsHttpOperation result, URI uri)
LOG.debug("ListBlobs listed {} blobs with {} as continuation token",
listResultSchema.paths().size(),
listResultSchema.getNextMarker());
- } catch (SAXException | IOException e) {
- throw new AbfsDriverException(e);
+ return filterDuplicateEntriesAndRenamePendingFiles(listResultSchema,
uri);
+ } catch (SAXException | IOException ex) {
+ throw new AbfsDriverException(ERR_BLOB_LIST_PARSING, ex);
Review Comment:
NIT: We can add URI in the error message for better visibility.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
