[
https://issues.apache.org/jira/browse/HADOOP-19548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17946920#comment-17946920
]
ASF GitHub Bot commented on HADOOP-19548:
-----------------------------------------
anujmodi2021 commented on code in PR #7642:
URL: https://github.com/apache/hadoop/pull/7642#discussion_r2057533364
##########
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/AzureBlobFileSystem.java:
##########
@@ -347,8 +347,9 @@ public void registerListener(Listener listener1) {
@Override
public FSDataInputStream open(final Path path, final int bufferSize) throws
IOException {
- LOG.debug("AzureBlobFileSystem.open path: {} bufferSize: {}", path,
bufferSize);
// bufferSize is unused.
+ LOG.debug("AzureBlobFileSystem.open path: {} bufferSize: {}", path,
Review Comment:
Trying to understand this from a user's perspective. If someone is calling
this method with a buffer size they expect that buffer size to get honoured and
if they really want that buffer size to be honored they should know how to make
that happen.
Let's add debug something like this: `AzureBlobFileSystem.open path: {}
bufferSize as configured in "fs.azure.read.request.size": {}", path,
abfsStore.getAbfsConfiguration().getReadBufferSize())`
> [ABFS] Fix logging in FSDataInputStream buffersize as that is not used and
> confusing the customer
> -------------------------------------------------------------------------------------------------
>
> Key: HADOOP-19548
> URL: https://issues.apache.org/jira/browse/HADOOP-19548
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: hadoop-common
> Affects Versions: 3.4.1
> Reporter: Mukund Thakur
> Assignee: Manika Joshi
> Priority: Major
> Labels: pull-request-available
>
> Fix debug logs here.
> https://github.com/apache/hadoop/blob/trunk/hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/AzureBlobFileSystem.java#L350
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
