[
https://issues.apache.org/jira/browse/HADOOP-19548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17948002#comment-17948002
]
ASF GitHub Bot commented on HADOOP-19548:
-----------------------------------------
manika137 commented on code in PR #7642:
URL: https://github.com/apache/hadoop/pull/7642#discussion_r2065332131
##########
hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestFileSystemProperties.java:
##########
@@ -135,4 +135,23 @@ public void testSetFileSystemProperties() throws Exception
{
assertEquals(properties, fetchedProperties);
}
+
+ @Test
+ //Test to verify buffersize remains the same as set in the configuration,
irrespective of the parameter passed to FSDataInputStream
+ public void testBufferSizeSet() throws Exception {
+ final AzureBlobFileSystem fs = getFileSystem();
+ AbfsConfiguration abfsConfig = fs.getAbfsStore().getAbfsConfiguration();
+ int bufferSizeConfig = 5 * 1024 * 1024;
+ int bufferSizeArg = 10 * 1024 * 1024;
+
+ Path testPath = path(TEST_PATH);
+ fs.create(testPath);
+
+ abfsConfig.setReadBufferSize(bufferSizeConfig);
+ fs.open(testPath, bufferSizeArg);
+ int actualBufferSize = abfsConfig.getReadBufferSize();
+
+ assertEquals(bufferSizeConfig, actualBufferSize);
+ assertNotEquals(bufferSizeArg, actualBufferSize);
Review Comment:
I believe the sequence is expected and then the actual value.
Will use AssertJs, thanks
> [ABFS] Fix logging in FSDataInputStream buffersize as that is not used and
> confusing the customer
> -------------------------------------------------------------------------------------------------
>
> Key: HADOOP-19548
> URL: https://issues.apache.org/jira/browse/HADOOP-19548
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: hadoop-common
> Affects Versions: 3.4.1
> Reporter: Mukund Thakur
> Assignee: Manika Joshi
> Priority: Major
> Labels: pull-request-available
>
> Fix debug logs here.
> https://github.com/apache/hadoop/blob/trunk/hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/AzureBlobFileSystem.java#L350
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
