slfan1989 commented on PR #7586: URL: https://github.com/apache/hadoop/pull/7586#issuecomment-2831959261
> `TestGetGroups` ran tests in the base class `GetGroupsTestBase`, which failed. Does JUnit 5 `@Disabled` not disable tests in superclasses? Would we need to override each method and apply method-level `@Disabled` annotations? @cnauroth Thank you for reviewing the code. Apologies for not noticing your comment earlier, as I was focused on upgrading other modules to JUnit 5. I believe your suggestion is correct, and I have made the necessary changes. However, I noticed that the unit tests are still being executed. I suspect this may be related to the fact that we are still in a mixed testing mode using both JUnit 4 and JUnit 5. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
