jojochuang commented on code in PR #7586:
URL: https://github.com/apache/hadoop/pull/7586#discussion_r2064154515
##########
hadoop-tools/hadoop-extras/src/test/java/org/apache/hadoop/mapred/tools/TestGetGroups.java:
##########
@@ -52,4 +53,33 @@ protected Tool getTool(PrintStream o) {
return new GetGroups(conf, o);
}
+ @Test
Review Comment:
Just curious. Are these test method overrides necessary?
##########
hadoop-tools/hadoop-extras/src/test/java/org/apache/hadoop/mapred/tools/TestGetGroups.java:
##########
@@ -24,25 +24,26 @@
import org.apache.hadoop.mapred.tools.GetGroups;
import org.apache.hadoop.tools.GetGroupsTestBase;
import org.apache.hadoop.util.Tool;
-import org.junit.After;
-import org.junit.Before;
-import org.junit.Ignore;
+import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.AfterEach;
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Disabled;
/**
* Tests for the MR implementation of {@link GetGroups}
*/
-@Ignore
+@Disabled
Review Comment:
The test was disabled 14 years ago
(https://issues.apache.org/jira/browse/MAPREDUCE-3860)
Maybe we should just remove it.... just saying.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
