[
https://issues.apache.org/jira/browse/HADOOP-19425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18013590#comment-18013590
]
ASF GitHub Bot commented on HADOOP-19425:
-----------------------------------------
anujmodi2021 commented on code in PR #7674:
URL: https://github.com/apache/hadoop/pull/7674#discussion_r2272195658
##########
hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/AbstractAbfsIntegrationTest.java:
##########
@@ -569,23 +569,24 @@ protected AbfsOutputStream
createAbfsOutputStreamWithFlushEnabled(
*/
protected long assertAbfsStatistics(AbfsStatistic statistic,
long expectedValue, Map<String, Long> metricMap) {
- assertEquals("Mismatch in " + statistic.getStatName(), expectedValue,
- (long) metricMap.get(statistic.getStatName()));
+ assertEquals(expectedValue, (long) metricMap.get(statistic.getStatName()),
+ "Mismatch in " + statistic.getStatName());
return expectedValue;
}
protected void assumeValidTestConfigPresent(final Configuration conf, final
String key) {
String configuredValue = conf.get(accountProperty(key, accountName),
conf.get(key, ""));
- Assume.assumeTrue(String.format("Missing Required Test Config: %s.", key),
- !configuredValue.isEmpty());
+ assumeThat(configuredValue)
+ .as(String.format("Missing Required Test Config: %s.", key))
+ .isNotEmpty();
}
protected void assumeValidAuthConfigsPresent() {
final AuthType currentAuthType = getAuthType();
- Assume.assumeFalse(
- "SAS Based Authentication Not Allowed For Integration Tests",
- currentAuthType == AuthType.SAS);
+ assumeThat(currentAuthType).
Review Comment:
This is working as assumeTrue but should have been working as assumeFalse.
This is leading to all Integration tests getting skipped.
Will fix this with https://issues.apache.org/jira/browse/HADOOP-19649
> [ABFS] Upgrade JUnit from 4 to 5 in hadoop-azure.
> -------------------------------------------------
>
> Key: HADOOP-19425
> URL: https://issues.apache.org/jira/browse/HADOOP-19425
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: build, fs/azure, test
> Affects Versions: 3.5.0
> Reporter: Shilun Fan
> Assignee: Shilun Fan
> Priority: Major
> Labels: pull-request-available
> Fix For: 3.5.0
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
