[ https://issues.apache.org/jira/browse/HADOOP-19425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18013609#comment-18013609 ]
ASF GitHub Bot commented on HADOOP-19425: ----------------------------------------- anujmodi2021 commented on code in PR #7674: URL: https://github.com/apache/hadoop/pull/7674#discussion_r2272370316 ########## hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestOauthOverAbfsScheme.java: ########## @@ -20,23 +20,25 @@ import java.lang.reflect.Field; import java.net.URL; -import org.junit.Assume; -import org.junit.Test; +import org.junit.jupiter.api.Test; import org.apache.hadoop.conf.Configuration; import org.apache.hadoop.fs.azurebfs.constants.FileSystemUriSchemes; import org.apache.hadoop.fs.azurebfs.services.AbfsClient; import org.apache.hadoop.fs.azurebfs.services.AuthType; import org.apache.hadoop.fs.CommonConfigurationKeysPublic; +import static org.assertj.core.api.Assumptions.assumeThat; + /** * Test Oauth fail fast when uri scheme is incorrect. */ public class ITestOauthOverAbfsScheme extends AbstractAbfsIntegrationTest { public ITestOauthOverAbfsScheme() throws Exception { - Assume.assumeTrue("ITestOauthOverAbfsScheme is skipped because auth type is not OAuth", - getAuthType() == AuthType.OAuth); + assumeThat(getAuthType()) + .as("ITestOauthOverAbfsScheme is skipped because auth type is not OAuth") + .isNotEqualTo(AuthType.OAuth); Review Comment: This also need fix. Will take up with https://issues.apache.org/jira/browse/HADOOP-19649 > [ABFS] Upgrade JUnit from 4 to 5 in hadoop-azure. > ------------------------------------------------- > > Key: HADOOP-19425 > URL: https://issues.apache.org/jira/browse/HADOOP-19425 > Project: Hadoop Common > Issue Type: Sub-task > Components: build, fs/azure, test > Affects Versions: 3.5.0 > Reporter: Shilun Fan > Assignee: Shilun Fan > Priority: Major > Labels: pull-request-available > Fix For: 3.5.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org