[
https://issues.apache.org/jira/browse/HADOOP-19824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18065823#comment-18065823
]
ASF GitHub Bot commented on HADOOP-19824:
-----------------------------------------
ajfabbri opened a new pull request, #8344:
URL: https://github.com/apache/hadoop/pull/8344
- Remove directory-maven-plugin used to compute repo.root.
- Replace uses of that variable with `../` or `../../` according to
directory structure.
- formatting: Strip trailing whitespace on save.
<!--
Thanks for sending a pull request!
1. If this is your first time, please read our contributor guidelines:
https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute
2. Make sure your PR title starts with JIRA issue id, e.g.,
'HADOOP-17799. Your PR title ...'.
-->
### Description of PR
Fixes running spotbugs with maven -pl <project>, e.g.
`mvn -pl hadoop-tools/hadoop-aws spotbugs:spotbugs`
### How was this patch tested?
```
mvnd clean
mvnd clean compile -pl hadoop-tools/hadoop-aws -am
mvnd -pl hadoop-tools/hadoop-aws -am spotbugs:spotbugs
```
### For code changes:
- [x] Does the title or this PR starts with the corresponding JIRA issue id
(e.g. 'HADOOP-17799. Your PR title ...')?
- [na] Object storage: have the integration tests been executed and the
endpoint declared according to the connector-specific documentation?
- [x] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [x] If applicable, have you updated the `LICENSE`, `LICENSE-binary`,
`NOTICE-binary` files?
### AI Tooling
If an AI tool was used:
- [na] The PR includes the phrase "Contains content generated by <tool>"
where <tool> is the name of the AI tool used.
- [na] My use of AI contributions follows the ASF legal policy
https://www.apache.org/legal/generative-tooling.html
> Build failure: Could not find resource '${repo.root}' ...
> ---------------------------------------------------------
>
> Key: HADOOP-19824
> URL: https://issues.apache.org/jira/browse/HADOOP-19824
> Project: Hadoop Common
> Issue Type: Bug
> Components: hadoop-common
> Affects Versions: 3.5.0
> Reporter: Aaron Fabbri
> Assignee: Aaron Fabbri
> Priority: Minor
>
> When trying to run `spotbugs` target on a submodule from the repo root, I'm
> getting a failure to resolve ${repo.root}. Reproduction:
>
> {{mvnd clean}}
> {{mvnd clean compile -pl hadoop-tools/hadoop-aws -am}}
> {{mvnd -pl hadoop-tools/hadoop-aws -am spotbugs:spotbugs}}
> {{...}}
> {{Could not find resource
> '${repo.root}/dev-support/findbugs-exclude-global.xml'}}
> Am I expected to `cd` into the submodule folder first? Do we really need this
> `directory-maven-plugin` which is supposed to compute `repo.root` for us? Why
> not just use relative paths (e.g. ../../)? I'm not very skilled with maven
> but this seems brittle.
> This repo.root thing was introduced for global excludes as part of a spotbugs
> upgrade in HADOOP-19731.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
