[ 
https://issues.apache.org/jira/browse/HADOOP-19824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18067740#comment-18067740
 ] 

ASF GitHub Bot commented on HADOOP-19824:
-----------------------------------------

roczei commented on PR #8344:
URL: https://github.com/apache/hadoop/pull/8344#issuecomment-4112055314

   Hi @ajfabbri 
   
   It looks like this commit is causing an error. For example, it's complaining 
about this in my PR:
   
   https://github.com/apache/hadoop/pull/8357
   
   
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8357/4/artifact/out/patch-spotbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-web-proxy.txt
   
   ```
   [ERROR] Could not find resource 
'../../dev-support/findbugs-exclude-global.xml'. -> [Help 1]
   ```
   
   Could you please fix it? Thanks!
   




> Build failure: Could not find resource '${repo.root}' ...
> ---------------------------------------------------------
>
>                 Key: HADOOP-19824
>                 URL: https://issues.apache.org/jira/browse/HADOOP-19824
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: hadoop-common
>    Affects Versions: 3.5.0
>            Reporter: Aaron Fabbri
>            Assignee: Aaron Fabbri
>            Priority: Minor
>              Labels: pull-request-available
>
> When trying to run `spotbugs` target on a submodule from the repo root, I'm 
> getting a failure to resolve ${repo.root}. Reproduction:
>  
> {{mvnd clean}}
> {{mvnd clean compile -pl hadoop-tools/hadoop-aws -am}}
> {{mvnd -pl hadoop-tools/hadoop-aws -am  spotbugs:spotbugs}}
> {{...}}
> {{Could not find resource 
> '${repo.root}/dev-support/findbugs-exclude-global.xml'}}
> Am I expected to `cd` into the submodule folder first? Do we really need this 
> `directory-maven-plugin` which is supposed to compute `repo.root` for us? Why 
> not just use relative paths (e.g. ../../)?  I'm not very skilled with maven 
> but this seems brittle.
> This repo.root thing was introduced for global excludes as part of a spotbugs 
> upgrade in HADOOP-19731.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to