[ 
https://issues.apache.org/jira/browse/HADOOP-8487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13409445#comment-13409445
 ] 

Daryn Sharp commented on HADOOP-8487:
-------------------------------------

A few small comments:
# In {{FileSystemTestHelper}}, does the {{final}} keyword need to be removed?
# In {{TestFSMainOperationsLocalFileSystem}}, are any changes actually needed?  
Ie. why override just to call {{super}}?
# In all of test class changes, please default to build/test/data.  Hardcoding 
/tmp may cause multiple test runs to collide.
                
> Many HDFS tests use a test path intended for local file system tests
> --------------------------------------------------------------------
>
>                 Key: HADOOP-8487
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8487
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: test
>            Reporter: Ivan Mitic
>            Assignee: Ivan Mitic
>         Attachments: HADOOP-8487-branch-1-win(2).patch, 
> HADOOP-8487-branch-1-win(3).patch, HADOOP-8487-branch-1-win.alternate.patch, 
> HADOOP-8487-branch-1-win.patch
>
>
> Many tests use a test path intended for local tests setup by build 
> environment. In some cases the tests fails on platforms such as windows 
> because the path contains a c:

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to