[
https://issues.apache.org/jira/browse/HADOOP-8487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13413443#comment-13413443
]
Ivan Mitic commented on HADOOP-8487:
------------------------------------
Thanks for reviewing Daryn.
bq. In FileSystemTestHelper, does the final keyword need to be removed?
We need this because we want to be able to override the value by tests
({{TestFSMainOperationsWebHdfs}} is one example). This path is not always used
in the context of the local path, and this causes problems on Windows, as paths
like {{c:/some/path/build/test/data}} are not valid DFS paths (because of the
colon).
bq. In TestFSMainOperationsLocalFileSystem, are any changes actually needed?
Ie. why override just to call super?
I think I saw this test failing on Windows because the super {{tearDown()}} was
not called, causing subsequent tests to fail (could it be related to junit
version?). Will try to repro the problem and report back.
bq. In all of test class changes, please default to build/test/data. Hardcoding
/tmp may cause multiple test runs to collide.
This is actually the test fix. Similar comment to #1, {{build.test.data}} is a
local path and given that it is used in HDFS tests, it fails the valid DFS path
check. IOW, these tests should not write to the local file system, and if I
understood your worry correctly, should not collide with other tests. We also
have the test name embedded in the path, so it should be easy to spot such
cases if they exists. Does it make sense?
> Many HDFS tests use a test path intended for local file system tests
> --------------------------------------------------------------------
>
> Key: HADOOP-8487
> URL: https://issues.apache.org/jira/browse/HADOOP-8487
> Project: Hadoop Common
> Issue Type: Bug
> Components: test
> Reporter: Ivan Mitic
> Assignee: Ivan Mitic
> Attachments: HADOOP-8487-branch-1-win(2).patch,
> HADOOP-8487-branch-1-win(3).patch, HADOOP-8487-branch-1-win.alternate.patch,
> HADOOP-8487-branch-1-win.patch
>
>
> Many tests use a test path intended for local tests setup by build
> environment. In some cases the tests fails on platforms such as windows
> because the path contains a c:
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
