[
https://issues.apache.org/jira/browse/HADOOP-19893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18098980#comment-18098980
]
ASF GitHub Bot commented on HADOOP-19893:
-----------------------------------------
steveloughran commented on code in PR #8530:
URL: https://github.com/apache/hadoop/pull/8530#discussion_r3647236377
##########
.github/workflows/report_cloud_aws.yml:
##########
@@ -32,8 +32,39 @@ permissions:
jobs:
report:
runs-on: ubuntu-latest
- if: github.event.workflow_run.event == 'pull_request'
+ if: (github.event.workflow_run.event == 'pull_request' ||
github.event.workflow_run.event == 'workflow_dispatch') &&
github.event.workflow_run.conclusion != 'skipped'
steps:
+ - name: Download manual target metadata
+ if: github.event.workflow_run.event == 'workflow_dispatch'
+ uses: actions/download-artifact@v5
Review Comment:
i think all those actions should have a hash with a version in a comment.
hash to pin to a commit; comment for dependabot to know what to update
uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 #
v7.0.0
> ci: s3a integration tests fail for fork PRs
> -------------------------------------------
>
> Key: HADOOP-19893
> URL: https://issues.apache.org/jira/browse/HADOOP-19893
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: ci, fs/s3
> Affects Versions: 3.5.0
> Reporter: Aaron Fabbri
> Assignee: Aaron Fabbri
> Priority: Major
> Labels: pull-request-available
>
> `.github/workflows/cloud_aws.yml` fails to execute when a PR branch is pushed
> to a fork repository. It works fine when pushing a branch to upstream
> (apache/hadoop). The problem is that the determination of the container image
> URL (which happens in `.github/actions/build_image_url/action.yml`) uses
> `apache` for `github.repository.owner` instead of `fork-owner`, due to use of
> `pull_request` trigger.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
