[
https://issues.apache.org/jira/browse/HADOOP-19893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18098998#comment-18098998
]
ASF GitHub Bot commented on HADOOP-19893:
-----------------------------------------
ajfabbri commented on PR #8530:
URL: https://github.com/apache/hadoop/pull/8530#issuecomment-5073447988
Thanks for the review!
> before committing, switch the uses declarations to use the checksum with a
version the comment for dependabot, as that's the only way to lock down
workflows
For first-party `uses:` workflows, there is an assumption that they are
using immutable releases (i.e. tags that cannot be moved). Also [ASF
policy](https://infra.apache.org/github-actions-policy.html) only requires SHA
version pins for third-party actions. There is no harm in adding git hashes
here though, so I'll do that.
> ci: s3a integration tests fail for fork PRs
> -------------------------------------------
>
> Key: HADOOP-19893
> URL: https://issues.apache.org/jira/browse/HADOOP-19893
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: ci, fs/s3
> Affects Versions: 3.5.0
> Reporter: Aaron Fabbri
> Assignee: Aaron Fabbri
> Priority: Major
> Labels: pull-request-available
>
> `.github/workflows/cloud_aws.yml` fails to execute when a PR branch is pushed
> to a fork repository. It works fine when pushing a branch to upstream
> (apache/hadoop). The problem is that the determination of the container image
> URL (which happens in `.github/actions/build_image_url/action.yml`) uses
> `apache` for `github.repository.owner` instead of `fork-owner`, due to use of
> `pull_request` trigger.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
