[
https://issues.apache.org/jira/browse/HADOOP-15190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18099967#comment-18099967
]
ASF GitHub Bot commented on HADOOP-15190:
-----------------------------------------
pan3793 commented on code in PR #8606:
URL: https://github.com/apache/hadoop/pull/8606#discussion_r3671992141
##########
BUILDING.txt:
##########
@@ -149,7 +149,18 @@ Maven build goals:
* Run checkstyle : mvn compile checkstyle:checkstyle
* Install JAR in M2 cache : mvn install
* Deploy JAR to Maven repo : mvn deploy
- * Run clover : mvn test -Pclover
+ * Run JaCoCo coverage : mvn verify -Dhadoop.skip-jacoco=false
-Dmaven.test.failure.ignore=true --fail-at-end
+ (aggregate report:
hadoop-coverage/target/site/jacoco-aggregate/index.html;
+ must be a full-reactor build, not -pl
hadoop-coverage.
+ --fail-at-end keeps the reactor
building/testing the modules
+ that don't depend on a hard-failing one (each
writing its
+ target/jacoco.exec) instead of stopping at the
first failure;
+ hadoop-coverage does not depend on the
catalog-webapp war, so
+ it still runs report-aggregate at the verify
phase.
+ -Dmaven.test.failure.ignore=true only
tolerates surefire *test*
+ failures; a plugin-level hard failure (e.g.
the catalog-webapp
+ jasmine/PhantomJS browser test in a headless
container) would
+ otherwise stop the reactor before the report
is produced.)
Review Comment:
can you keep the single-line command here, and move this section below?
e.g., after `Special plugins: OWASP's dependency-check:` section
> Use Jacoco to generate Unit Test coverage reports
> -------------------------------------------------
>
> Key: HADOOP-15190
> URL: https://issues.apache.org/jira/browse/HADOOP-15190
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build
> Reporter: Duo Xu
> Assignee: Ferenc Erdelyi
> Priority: Minor
> Labels: pull-request-available
> Attachments: HADOOP-15190-design_2026_July_16.txt,
> HADOOP-15190.01.patch, aggregate_coverage_report_demo_2026_july_17.png,
> hadoop_nfs_jacoco_report_2026_july_17.png, jacoco_report_2018_01_25.JPG
>
>
> Currently Hadoop is using maven-clover2-plugin for code coverage, which is
> outdated. And Atlassian open-sourced clover last year so license cannot be
> purchased although we can switch to use the license-free version called
> "openclover".
> This Jira is to replace clover with Jacoco, which is actively maintained by
> the community.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
