[ 
https://issues.apache.org/jira/browse/HADOOP-15190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18100033#comment-18100033
 ] 

ASF GitHub Bot commented on HADOOP-15190:
-----------------------------------------

ferdelyi commented on code in PR #8606:
URL: https://github.com/apache/hadoop/pull/8606#discussion_r3673522388


##########
hadoop-project/pom.xml:
##########
@@ -203,7 +206,6 @@
     <maven-pdf-plugin.version>1.2</maven-pdf-plugin.version>
     
<maven-remote-resources-plugin.version>1.5</maven-remote-resources-plugin.version>
     <build-helper-maven-plugin.version>1.9</build-helper-maven-plugin.version>
-    <exec-maven-plugin.version>1.3.1</exec-maven-plugin.version>

Review Comment:
   To clarify, this was never an upgrade — 1.3.1 is unchanged. The PR had 
relocated exec-maven-plugin's version management from hadoop-project up to the 
root pom: hadoop-coverage's module-list guard runs via exec-maven-plugin, and 
since that module inherits from hadoop-main (not hadoop-project) it couldn't 
see hadoop-project's management, so it needed the version at the root — which 
made the hadoop-project entry redundant, hence removed.
   
   Since then I've reworked it so no shared poms are touched at all: root 
pom.xml and hadoop-project/pom.xml are back to trunk, and the version is now 
pinned locally in hadoop-coverage/pom.xml itself. So there's no longer any 
shared or unrelated change, and nothing that needs a separate PR.





> Use Jacoco to generate Unit Test coverage reports
> -------------------------------------------------
>
>                 Key: HADOOP-15190
>                 URL: https://issues.apache.org/jira/browse/HADOOP-15190
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: build
>            Reporter: Duo Xu
>            Assignee: Ferenc Erdelyi
>            Priority: Minor
>              Labels: pull-request-available
>         Attachments: HADOOP-15190-design_2026_July_16.txt, 
> HADOOP-15190.01.patch, aggregate_coverage_report_demo_2026_july_17.png, 
> hadoop_nfs_jacoco_report_2026_july_17.png, jacoco_report_2018_01_25.JPG
>
>
> Currently Hadoop is using maven-clover2-plugin for code coverage, which is 
> outdated. And Atlassian open-sourced clover last year so license cannot be 
> purchased although we can switch to use the license-free version called 
> "openclover".
> This Jira is to replace clover with Jacoco, which is actively maintained by 
> the community.
>   



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to