ferdelyi commented on code in PR #8606:
URL: https://github.com/apache/hadoop/pull/8606#discussion_r3673480371
##########
hadoop-project/pom.xml:
##########
@@ -2627,6 +2618,33 @@
</excludes>
</configuration>
</plugin>
+ <plugin>
+ <groupId>org.jacoco</groupId>
+ <artifactId>jacoco-maven-plugin</artifactId>
+ <executions>
+ <execution>
+ <id>prepare-agent</id>
+ <goals>
+ <goal>prepare-agent</goal>
+ </goals>
+ <configuration>
+ <skip>${hadoop.skip-jacoco}</skip>
Review Comment:
@pan3793 thank you for this question. The custom hadoop.skip-jacoco was
originally meant as a single Hadoop-owned switch covering the whole coverage
feature — both the plugin executions and whether the hadoop-coverage aggregate
module joins the reactor — while leaving ad-hoc jacoco:report runs working
without a flag. But you're right that a bespoke property isn't worth it when
the plugin already exposes jacoco.skip. I've switched to jacoco.skip (default
true in the root pom so hadoop-coverage resolves it too; enable with
-Djacoco.skip=false) and dropped the now-redundant explicit <skip> elements.
The only behavior change is that coverage is now opt-in everywhere, so a bare
mvn jacoco:report is skipped unless -Djacoco.skip=false is passed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
