ferdelyi commented on code in PR #8606:
URL: https://github.com/apache/hadoop/pull/8606#discussion_r3673522388
##########
hadoop-project/pom.xml:
##########
@@ -203,7 +206,6 @@
<maven-pdf-plugin.version>1.2</maven-pdf-plugin.version>
<maven-remote-resources-plugin.version>1.5</maven-remote-resources-plugin.version>
<build-helper-maven-plugin.version>1.9</build-helper-maven-plugin.version>
- <exec-maven-plugin.version>1.3.1</exec-maven-plugin.version>
Review Comment:
To clarify, this was never an upgrade — 1.3.1 is unchanged. The PR had
relocated exec-maven-plugin's version management from hadoop-project up to the
root pom: hadoop-coverage's module-list guard runs via exec-maven-plugin, and
since that module inherits from hadoop-main (not hadoop-project) it couldn't
see hadoop-project's management, so it needed the version at the root — which
made the hadoop-project entry redundant, hence removed.
Since then I've reworked it so no shared poms are touched at all: root
pom.xml and hadoop-project/pom.xml are back to trunk, and the version is now
pinned locally in hadoop-coverage/pom.xml itself. So there's no longer any
shared or unrelated change, and nothing that needs a separate PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
