ferdelyi commented on code in PR #8621:
URL: https://github.com/apache/hadoop/pull/8621#discussion_r3676707203
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-catalog/hadoop-yarn-applications-catalog-webapp/pom.xml:
##########
@@ -484,7 +484,14 @@
</execution>
</executions>
<configuration>
- <skipJasmineTests>${skipTests}</skipJasmineTests>
+ <!-- No explicit skipJasmineTests element: the plugin
already
+ binds skipTests, maven.test.skip and skipJasmineTests
to the
+ matching command-line properties and skips when any
is true.
+ Setting the element here would override those
bindings, so
+ -DskipJasmineTests would be ignored. Omitting it lets
+ -DskipTests skip jasmine (as before) while
-DskipJasmineTests=true
+ skips only the browser-driven specs (e.g. on a
headless box
+ with no PhantomJS) without disabling the module's
other tests. -->
Review Comment:
Thank you for the review, @pan3793! Both addressed in the latest commit:
1. Comment verbosity — trimmed the pom comment down to your suggested
wording:
<!-- Jasmine tests are skipped if any one of -Dmaven.test.skip=true,
-DskipTests, -DskipJasmineTests=true is set. Don't declare
skipJasmineTests here: it would override those command-line flags. -->
I kept a one-line "don't declare skipJasmineTests here" note, since a
hardcoded element is exactly what was silently disabling the flag before — to
guard against a re-add.
2. BUILDING.txt — added a bullet under Tests options:
* Use -DskipJasmineTests=true to skip only the browser-driven jasmine tests
in
hadoop-yarn-applications-catalog-webapp (e.g. on a headless machine with
no
browser) while still running the module's other tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
