joseluisll commented on PR #8717: URL: https://github.com/apache/hadoop/pull/8717#issuecomment-5813605599
Thanks for the review @slfan1989 - all three addressed in 822d705. > Small documentation nit: could you update "Existing tests; test-only change" in the PR description? You're right, and it was understating the change rather than just mis-wording it. The description now carries the `TimelineReaderServer.serviceStop()` change explicitly, says why the test fix rests on it, and "How was this patch tested?" lists the new regression test instead of claiming existing tests cover everything. The other two are answered in their threads: `getResponseCode()` in place of `getInputStream()` in `TestSSLHttpServerMTLS` (30/30 under both TLSv1.2 and TLSv1.3), and `TestTimelineReaderServer.testChildServicesStoppedWhenWebAppStopFails` for the exceptional stop path, verified to fail without the `finally`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
