joseluisll commented on code in PR #8699:
URL: https://github.com/apache/hadoop/pull/8699#discussion_r4097691775
##########
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/JobEndNotifier.java:
##########
@@ -141,24 +145,24 @@ protected boolean notifyURLOnce() {
private boolean notifyViaBuiltInNotifier() {
boolean success = false;
try {
- Log.getLog().info("Job end notification trying " + urlToNotify);
+ LOG.info("Job end notification trying " + urlToNotify);
HttpURLConnection conn =
(HttpURLConnection) urlToNotify.openConnection(proxyToUse);
conn.setConnectTimeout(timeout);
conn.setReadTimeout(timeout);
conn.setAllowUserInteraction(false);
if(conn.getResponseCode() != HttpURLConnection.HTTP_OK) {
- Log.getLog().warn("Job end notification to " + urlToNotify
+ LOG.warn("Job end notification to " + urlToNotify
+ " failed with code: " + conn.getResponseCode() + " and message
\""
+ conn.getResponseMessage() + "\"");
}
else {
success = true;
- Log.getLog().info("Job end notification to " + urlToNotify
+ LOG.info("Job end notification to " + urlToNotify
Review Comment:
Agreed on both counts. I have filed MAPREDUCE-7544 for the SLF4J switch and
it is being prepared as a separate PR, with the `{}` placeholder style applied,
so it can be reviewed and backported on its own as you suggested.
I will drop the change from this PR and rebase on top of MAPREDUCE-7544 once
it lands. `hadoop-mapreduce-client-app` then needs no Jetty declaration at all,
since JobEndNotifier is its only Jetty reference in main sources — which is
what your question on the pom was really pointing at.
Eight test classes still use the same Jetty logging facade (four in
hadoop-common, two in hadoop-yarn-client, one each in
hadoop-yarn-server-applicationhistoryservice and
hadoop-yarn-server-resourcemanager). I have left those out to keep
MAPREDUCE-7544 small enough to backport cleanly; happy to do them as a
follow-up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
