craffit opened a new pull request, #8777: URL: https://github.com/apache/hadoop/pull/8777
### Description of PR JIRA: https://issues.apache.org/jira/browse/HDFS-17983 A packet write that fails after its data reached the block file but before `bytesOnDisk` is updated (e.g. `ClosedByInterruptException` while syncing) leaves an RBW replica whose block file is longer than `bytesOnDisk`. Lease/block recovery then rejects that replica in `checkReplicaFiles` ("Block length mismatch"), even though it holds all acknowledged data. `FsDatasetImpl#initReplicaRecoveryImpl` now truncates the block and meta file to `bytesOnDisk` in that case, as `recoverRbwImpl` already does for pipeline recovery since HDFS-11472. The existing `bytesOnDisk >= visibleLength` check runs first, so no acknowledged bytes are dropped. ### How was this patch tested? Added `TestLeaseRecovery#testLeaseRecoveryAfterInterruptedPacketWrite`, which interrupts the DataNode receiver after a packet's data is written so the following fsync fails, and checks that lease recovery closes the file at the acknowledged length. ### For code changes: - [x] Does the title of this PR start with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')? - [ ] Object storage: Have the integration tests been executed and the endpoint declared according to the connector-specific documentation? (N/A) - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? (N/A) - [ ] If applicable, have you updated the `LICENSE`, `LICENSE-binary`, `NOTICE-binary` files? (N/A) ### AI Tooling If an AI tool was used: - [x] The PR includes the phrase "Contains content generated by <tool>" where <tool> is the name of the AI tool used. - [x] My use of AI contributions follows the ASF legal policy https://www.apache.org/legal/generative-tooling.html Contains content generated by Claude Code. 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
