joseluisll commented on PR #8818:
URL: https://github.com/apache/hadoop/pull/8818#issuecomment-6153991717

   The -1 overall comes only from the **trunk (base) spotbugs** check. The 
patch doesn't introduce it.
   
   - **spotbugs -1 (trunk):** Yetus runs SpotBugs on trunk before applying the 
patch, and trunk has the 21 existing `hadoop-distcp` warnings that this PR 
fixes. With the patch applied the result is `0 new + 0 unchanged - 21 fixed = 0 
total (was 21)`.
   - **patch -0 ("Used diff version of patch file"):** CI downloaded the PR's 
HTML page instead of the `.patch` file, so Yetus used the `.diff`. All 12 files 
applied cleanly, and Yetus leaves this vote out of the overall result.
   - Everything else on the patch is +1, including the `hadoop-distcp` unit 
tests (401 run, 0 failures, 0 errors).
   
   The trunk spotbugs -1 will stay until this change is merged.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to