joseluisll commented on PR #8818: URL: https://github.com/apache/hadoop/pull/8818#issuecomment-6480684594
Thanks @ayushtkn. I solved some spotbugs by exception per module, but others I changed what callers see, not only what SpotBugs reports: - `CopyListingFileStatus#setAclEntries`, `#setXAttrs`, `DistCpContext#setSourcePaths` and the `DistCpOptions.Builder` constructor now copy the collection they are given, so later changes by the caller are no longer seen. - `DistCpContext#getSourcePaths` now returns an unmodifiable view. - `DistCpOptionSwitch#getOption` now returns a clone instead of the shared `Option`. The tests cover those changes, and each one fails against trunk. If you want, I cut down the tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
