vt921102 commented on PR #8693:
URL: https://github.com/apache/hadoop/pull/8693#issuecomment-6407064032
Gentle ping on this backport.
#8692 (`branch-3.5`) was merged on 12 Oct, and HADOOP-19973 is now Reopened
to
track this remaining `branch-3.4` cherry-pick. Could **3.4.4** be added back
to
Fix Version/s when this one goes in?
Status as of today:
- **Apache Yetus: +1 overall**, no negative rows.
- `continuous-integration/jenkins/pr-merge`: green.
- **Integration validation: done and posted on 12 Oct** (comment above). Full
`hadoop-azure` suite, patched vs baseline on the same VM and the same ADLS
Gen2
account, **on Windows and on JDK 8** — 1531 vs 1530 tests, 39 unique
failing
entries each of which 38 are identical, the two differences being known
flaky
tests that cancel out. `TestAbfsClient` goes 2 -> 3 tests, both runs with
zero
failures, which is the part that proves the JUnit 4 adaptation in this
backport
compiles and passes under Java 8.
- The red **`Build`** check is structural, not a real failure: it is the
GitHub
Actions `build_and_test.yml` reusable workflow, added to trunk by
HADOOP-19858
after `branch-3.4` was cut, so `notify_test_workflow.yml` can never find a
run
for it and it reports `action_required` on every `branch-3.4` PR. Recent
`branch-3.4` merges have all gone in with it red.
Why this branch matters to us: `branch-3.4` is the last Hadoop line
supporting
Java 8, which our product still runs on, so we cannot pick the fix up from
3.5.1.
And the defect only reproduces where `File.separator` is a backslash — so
Windows
plus JDK 8 is exactly the combination this backport needs to be verified on,
which is what the run above covers.
The PR still merges cleanly on the current `branch-3.4` head (`95ca3f0ccd`).
If
you would rather see results against that head than against the commit I
tested,
say the word and I will rebase and re-run the Windows/JDK 8 validation.
@anujmodi2021 — would you be able to merge this, or point me at whatever is
still
missing? @steveloughran, cc'ing you since you merged the 3.5 cherry-pick,
but no
rush given your break.
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
