[ 
https://issues.apache.org/jira/browse/HADOOP-20030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18136534#comment-18136534
 ] 

ASF GitHub Bot commented on HADOOP-20030:
-----------------------------------------

hadoop-yetus commented on PR #8879:
URL: https://github.com/apache/hadoop/pull/8879#issuecomment-6581222356

   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |:----:|----------:|--------:|:--------:|:-------:|
   | +0 :ok: |  reexec  |   0m 35s |  |  Docker mode activated.  |
   |||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  |  No case conflicting files 
found.  |
   | +0 :ok: |  codespell  |   0m  0s |  |  codespell was not available.  |
   | +0 :ok: |  detsecrets  |   0m  0s |  |  detect-secrets was not available.  
|
   | +0 :ok: |  yamllint  |   0m  0s |  |  yamllint was not available.  |
   | +0 :ok: |  xmllint  |   0m  0s |  |  xmllint was not available.  |
   | +1 :green_heart: |  @author  |   0m  0s |  |  The patch does not contain 
any @author tags.  |
   | -1 :x: |  test4tests  |   0m  0s |  |  The patch doesn't appear to include 
any new or modified tests. Please justify why no new tests are needed for this 
patch. Also please list what manual steps were performed to verify this patch.  
|
   |||| _ trunk Compile Tests _ |
   | +0 :ok: |  mvndep  |   2m  3s |  |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |  45m  0s |  |  trunk passed  |
   | +1 :green_heart: |  compile  |  17m 13s |  |  trunk passed with JDK 
Ubuntu-21.0.12.1+1-1-24.04.4-Ubuntu  |
   | +1 :green_heart: |  compile  |  17m 51s |  |  trunk passed with JDK 
Ubuntu-17.0.20.1+1-1-24.04-Ubuntu  |
   | +1 :green_heart: |  mvnsite  |  19m 37s |  |  trunk passed  |
   | +1 :green_heart: |  javadoc  |  10m  7s |  |  trunk passed with JDK 
Ubuntu-21.0.12.1+1-1-24.04.4-Ubuntu  |
   | +1 :green_heart: |  javadoc  |  10m  5s |  |  trunk passed with JDK 
Ubuntu-17.0.20.1+1-1-24.04-Ubuntu  |
   | +1 :green_heart: |  shadedclient  | 151m 53s |  |  branch has no errors 
when building and testing our client artifacts.  |
   |||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 48s |  |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |  38m 46s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |  17m 22s |  |  the patch passed with JDK 
Ubuntu-21.0.12.1+1-1-24.04.4-Ubuntu  |
   | +1 :green_heart: |  javac  |  17m 22s |  |  the patch passed  |
   | +1 :green_heart: |  compile  |  17m 38s |  |  the patch passed with JDK 
Ubuntu-17.0.20.1+1-1-24.04-Ubuntu  |
   | +1 :green_heart: |  javac  |  17m 38s |  |  the patch passed  |
   | +1 :green_heart: |  blanks  |   0m  0s |  |  The patch has no blanks 
issues.  |
   | +1 :green_heart: |  mvnsite  |  19m 42s |  |  the patch passed  |
   | +1 :green_heart: |  javadoc  |  10m  5s |  |  the patch passed with JDK 
Ubuntu-21.0.12.1+1-1-24.04.4-Ubuntu  |
   | +1 :green_heart: |  javadoc  |   9m 56s |  |  the patch passed with JDK 
Ubuntu-17.0.20.1+1-1-24.04-Ubuntu  |
   | +1 :green_heart: |  shadedclient  |  72m 58s |  |  patch has no errors 
when building and testing our client artifacts.  |
   |||| _ Other Tests _ |
   | +1 :green_heart: |  unit  | 774m 29s |  |  root in the patch passed.  |
   | +1 :green_heart: |  asflicense  |   2m  1s |  |  The patch does not 
generate ASF License warnings.  |
   |  |   | 1079m 26s |  |  |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | ClientAPI=1.56 ServerAPI=1.56 base: 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8879/2/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hadoop/pull/8879 |
   | Optional Tests | dupname asflicense codespell detsecrets yamllint compile 
javac javadoc mvninstall mvnsite unit shadedclient xmllint |
   | uname | Linux 16a6eda3d703 5.15.0-198-generic #208-Ubuntu SMP Fri Sep 4 
10:22:38 UTC 2026 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/bin/hadoop.sh |
   | git revision | trunk / cdab7db5af1ba47212b5dd7ee1e8d57a50684864 |
   | Default Java | Ubuntu-17.0.20.1+1-1-24.04-Ubuntu |
   | Multi-JDK versions | 
/usr/lib/jvm/java-21-openjdk-amd64:Ubuntu-21.0.12.1+1-1-24.04.4-Ubuntu 
/usr/lib/jvm/java-17-openjdk-amd64:Ubuntu-17.0.20.1+1-1-24.04-Ubuntu |
   |  Test Results | 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8879/2/testReport/ |
   | Max. process+thread count | 3680 (vs. ulimit of 10000) |
   | modules | C: hadoop-project . U: . |
   | Console output | 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8879/2/console |
   | versions | git=2.43.0 maven=3.9.15 |
   | Powered by | Apache Yetus 0.14.1 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   




> Add an opt-in Maven profile and CI job that run tests with IPv6 enabled
> -----------------------------------------------------------------------
>
>                 Key: HADOOP-20030
>                 URL: https://issues.apache.org/jira/browse/HADOOP-20030
>             Project: Hadoop Common
>          Issue Type: Sub-task
>            Reporter: Siyao Meng
>            Assignee: Siyao Meng
>            Priority: Major
>              Labels: ipv6, pull-request-available
>
> The default surefire configuration sets {{java.net.preferIPv4Stack=true}} for 
> every test JVM:
> {code:xml}
> <java.net.preferIPv4Stack>true</java.net.preferIPv4Stack>
> {code}
> [hadoop-project/pom.xml:2624|https://github.com/apache/hadoop/blob/1097744bc490b65cad5ab2fbeafff35687971357/hadoop-project/pom.xml#L2624]
> With that setting the JVM uses IPv4-only sockets, so tests cannot exercise 
> IPv6 code paths even on a host with IPv6 loopback. There is also no CI job 
> for IPv6. The IPv6 fixes under HADOOP-11890 therefore have unit tests for 
> parsing and formatting, but nothing runs servers or clients over IPv6 in CI.
> *Proposal:*
> * Add an opt-in {{ipv6-test}} Maven profile that sets 
> {{java.net.preferIPv4Stack=false}} and {{java.net.preferIPv6Addresses=true}} 
> for surefire. The default build is unchanged.
> * Add a GitHub Actions workflow that runs a selected set of IPv6 tests under 
> that profile. IPv6 loopback ({{::1}}) is available on hosted runners without 
> outbound IPv6.
> * Optionally, a manually triggered job that builds the distribution and runs 
> a small IPv6-only docker-compose cluster smoke test.
> Changing the default to dual-stack for all tests is a separate decision and 
> is not proposed here.
> POC: 
> https://github.com/smengcl/hadoop/commit/3aa86b3ccdebf594d7661786c22ce54e2c6baad1
>  (profile) and 
> https://github.com/smengcl/hadoop/commit/f0ed93b0eac18e19e391e2a6812b0f343ec0e20d
>  (workflow)



--
This message was sent by Atlassian Jira
(v10.3.26#10030026)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to